Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: delete unreachable branches #466

Merged
merged 1 commit into from
Jun 18, 2022
Merged

refactor: delete unreachable branches #466

merged 1 commit into from
Jun 18, 2022

Conversation

zekth
Copy link
Member

@zekth zekth commented Jun 18, 2022 •
edited by Fdawgs
Loading

Since #441 , the skipQuotes branches are not used and not needed anymore because we use ajv to validate the dates.

mention @ivan-tymoshenko

Checklist

@zekth zekth changed the title feat: delete unreachable breanches feat: delete unreachable branches Jun 18, 2022
@Fdawgs Fdawgs changed the title feat: delete unreachable branches refactor: delete unreachable branches Jun 18, 2022
Fdawgs
Fdawgs approved these changes Jun 18, 2022
View reviewed changes
Copy link
Member

@Fdawgs Fdawgs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, renamed PR because this isn't introducing a new feature. 😸

ivan-tymoshenko
ivan-tymoshenko approved these changes Jun 18, 2022
View reviewed changes
Copy link
Member

@ivan-tymoshenko ivan-tymoshenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fdawgs Fdawgs merged commit 8a8b4e9 into fastify:master Jun 18, 2022
@zekth zekth deleted the feat/delete-unreachable-path branch June 18, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdawgs Fdawgs Fdawgs approved these changes

@ivan-tymoshenko ivan-tymoshenko ivan-tymoshenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zekth @ivan-tymoshenko @Fdawgs